I can’t be sure when this started, but it is recent… Selecting Alerts → Alert History gives:
No results found!
If we select Export to PDF, the resulting PDF contains the correct data…
====================================
Component
Version
LibreNMS
1.58.1-66-ga0e971659
DB Schema
2019_10_21_105350_devices_group_perms (149)
PHP
7.2.19-0ubuntu0.18.04.2
MySQL
10.1.41-MariaDB-0ubuntu0.18.04.1
RRDTool
1.7.0
SNMP
NET-SNMP 5.7.3
====================================
[OK] Composer Version: 1.9.1
Hi @JohnSPeach
@louis By chance, would you have a few minutes to have a look at this, and see if it could be a side effect of the recent AlertHistory updates ? Thanx
louis
2 January 2020 11:40
4
I am able to reproduce the issue.
louis
2 January 2020 13:08
5
Broken down by this change
librenms:master ← Jellyfrog:feature/devicegroup-permission
opened 01:41PM - 29 Aug 19 UTC
If you have many devices it's a big burden to add access to each new device.
Id… ea here is to add support to also allow access to devices based on device group membership.
There are a lot of places where this won't work currently, mostly due to the old codebase that runs raw SQL queries, in fact the only place it works at the moment is the pages under `/device/`.
Many of the pages can be fixed with a generic copy-paste solution, some requires more work, but the real solution is to convert them all to laravel/eloquent.
I suggest we mark this as "experimental" and release it as is (when we're happy with it)
Then I can look into converting more pages.
DO NOT DELETE THIS TEXT
#### Please note
> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.
- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)
#### Testers
If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
After you are done testing, you can remove the changes with `./scripts/github-remove`. If there are schema changes, you can ask on discord how to revert.
Fixed in
librenms:master ← louis-6wind:fix-alert-history
opened 01:26PM - 02 Jan 20 UTC
Alert history broken down by https://github.com/librenms/librenms/pull/10568
… DO NOT DELETE THIS TEXT
#### Please note
> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.
- [X] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)
#### Testers
If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
After you are done testing, you can remove the changes with `./scripts/github-remove`. If there are schema changes, you can ask on discord how to revert.
That fixes the problem for me.
Woopsie, by bad.
I also submitted a bit bigger patch; https://github.com/librenms/librenms/pull/10991