API /api/v0/devicesgroups/:name/maintenance - "Server Error: Set APP_DEBUG=true to see details."

rhinoau · 28 July 2022 04:46

PR to answer my own conjecture:

github.com/librenms/librenms

Standardize device and device group maintenance API

librenms:master ← rhinoau:maintenance

opened 04:45AM - 28 Jul 22 UTC

rhinoau

+116 -22

This PR standardises the behaviour of the devices and devicegroups maintenance A…PI: - defaults to immediate `now()` maintenance if no start given - accepts scheduled maintenance start if given - handles host not found errors cleanly - documentation clarity Prior, the two routines made different assumptions, devices could only have immediate maintenance, and basic errors were not handled for omitted data or device not found. DO NOT DELETE THE UNDERLYING TEXT #### Please note > Please read this information carefully. You can run `./lnms dev:check` to check your code before submitting. - [ ] Have you followed our [code guidelines?](https://docs.librenms.org/Developing/Code-Guidelines/) - [ ] If my Pull Request does some changes/fixes/enhancements in the WebUI, I have inserted a screenshot of it. - [ ] If my Pull Request makes discovery/polling/yaml changes, I have added/updated [test data](https://docs.librenms.org/Developing/os/Test-Units/). #### Testers If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926` After you are done testing, you can remove the changes with `./scripts/github-remove`. If there are schema changes, you can ask on discord how to revert.