Bug: librenms fails to find all device groups containing only numbers in name

chancez · 4 March 2021 17:48

Example:

~ czibolski ❯❯❯ curl -H "X-Auth-Token: $LIBRE_TOKEN" https://librenms.infra.rigetti.com/api/v0/devicegroups/FMT
{
    "status": "ok",
    "devices": [
        {
            "device_id": 8
        },
        {
            "device_id": 9
        },
        {
            "device_id": 25
        },
        {
            "device_id": 26
        },
        {
            "device_id": 27
        },
        {
            "device_id": 28
        },
        {
            "device_id": 29
        },
        {
            "device_id": 30
        },
        {
            "device_id": 31
        }
    ],
    "count": 9
}%
~ czibolski ❯❯❯ curl -H "X-Auth-Token: $LIBRE_TOKEN" https://librenms.infra.rigetti.com/api/v0/devicegroups/775
{
    "status": "error",
    "message": "Device group not found"
}%

github.com

librenms/librenms/blob/5388a20c09818823b6b2d47ba0a428fd728e90be/includes/html/api_functions.inc.php#L1914


    return api_success($groups->makeHidden('pivot')->toArray(), 'groups', 'Found ' . $groups->count() . ' device groups');
}
function get_devices_by_group(Illuminate\Http\Request $request)
{
    $name = $request->route('name');
    if (! $name) {
        return api_error(400, 'No device group name provided');
    }
    $device_group = ctype_digit($name) ? DeviceGroup::find($name) : DeviceGroup::where('name', $name)->first();
    if (empty($device_group)) {
        return api_error(404, 'Device group not found');
    }
    $devices = $device_group->devices()->get($request->get('full') ? ['*'] : ['devices.device_id']);
    if ($devices->isEmpty()) {
        return api_error(404, 'No devices found in group ' . $name);
    }

You can see it’s calling ctype_digit($name) which according to documentation (https://www.php.net/manual/en/function.ctype-digit.php) fails if it’s an integer, rather than a string containing an integer, eg:

$numeric_string = '42';
$integer        = 42;

ctype_digit($numeric_string);  // true
ctype_digit($integer);         // false (ASCII 42 is the * character)

system · 6 September 2021 17:48

This topic was automatically closed 186 days after the last reply. New replies are no longer allowed.