Eaton SC200 Support Improvement (Summary Alarm) (diff included)

Hy there,

I am new to librenms and today I created my first adjustment of an existing discovery yaml file - namely for Eaton SC200 (-48V UPS):

diff --git a/includes/definitions/discovery/eaton-sc200.yaml b/includes/definitions/discovery/eaton-sc200.yaml
index a6e7ae249..5154fab34 100644
--- a/includes/definitions/discovery/eaton-sc200.yaml
+++ b/includes/definitions/discovery/eaton-sc200.yaml
@@ -151,3 +151,24 @@ modules:
                       oid: di-Status
                       op: '=='
                       value: "0"
+                -
+                    oid: summary-Alarm-Critical
+                    num_oid: '.1.3.6.1.4.1.1918.2.13.10.110.5.10.0'
+                    descr: 'Summary Alarm Critical'
+                    states:
+                      - { descr: 'OK',      graph: 0, value: 0, generic: 0 }
+                      - { descr: 'Active',  graph: 1, value: 1, generic: 1 }
+                -
+                    oid: summary-Alarm-Major
+                    num_oid: '.1.3.6.1.4.1.1918.2.13.10.110.5.20.0'
+                    descr: 'Summary Alarm Major'
+                    states:
+                      - { descr: 'OK',      graph: 0, value: 0, generic: 0 }
+                      - { descr: 'Active',  graph: 1, value: 1, generic: 1 }
+                -
+                    oid: summary-Alarm-Minor
+                    num_oid: '.1.3.6.1.4.1.1918.2.13.10.110.5.30.0'
+                    descr: 'Summary Alarm Minor'
+                    states:
+                      - { descr: 'OK',      graph: 0, value: 0, generic: 0 }
+                      - { descr: 'Active',  graph: 1, value: 1, generic: 1 }

This creates there more states for summarizing alarms of different levels.

I had been able to test it roughly and it seems to work (If I have summary alarms, it gets into active state and goes back if Summary alarm are cleared in UPS WebUI)

Not sure if I did everything correct, so I’d like to post it and ask for a checkup and if found good putting it into upstream.

Is there anything to do better? I did not use indexes (does it make sense in this context?)

Best
DasDromedar