Possible Bug - Repeating OSPF Table

Help
#1

When asking for help and support, please provide as much information as possible. This should include:

  • Steps to reproduce an issue.
  • The output of ./validate.php

[email protected]:/opt/librenms# ./validate.php

Component Version
LibreNMS 1.42.01-58-g29d51f4
DB Schema 259
PHP 7.0.30-0ubuntu0.16.04.1
MySQL 10.0.34-MariaDB-0ubuntu0.16.04.1
RRDTool 1.5.5
SNMP NET-SNMP 5.7.3
====================================

[OK] Composer Version: 1.7.2
[OK] Dependencies up-to-date.
[OK] Database connection successful
[OK] Database schema correct
[WARN] Your local git contains modified files, this could prevent automatic updates.
[FIX] You can fix this with ./scripts/github-remove
Modified Files:
scripts/gen_smokeping.php

When adding a router it keeps adding ospf neighbor table

image
image1868×541 29.2 KB

its like its in a loop

#2

Its doing the same for all my other ospf enable routers I have added

image
image871×88 2.83 KB

#3

Do you mind testing https://github.com/librenms/librenms/pull/9051 ??

FYI. Always run librenms commands as librenms user or you can end with a lot of errors :wink:

#4

./scripts/github-apply 9051
Checking patch app/Models/OspfArea.php…
Checking patch app/Models/OspfInstance.php…
Checking patch app/Models/OspfNbr.php…
Checking patch app/Models/OspfPort.php…
Checking patch includes/polling/ospf.inc.php…
Checking patch misc/db_schema.yaml…
Checking patch sql-schema/260.sql…
Applied patch app/Models/OspfArea.php cleanly.
Applied patch app/Models/OspfInstance.php cleanly.
Applied patch app/Models/OspfNbr.php cleanly.
Applied patch app/Models/OspfPort.php cleanly.
Applied patch includes/polling/ospf.inc.php cleanly.
Applied patch misc/db_schema.yaml cleanly.
Applied patch sql-schema/260.sql cleanly.

let me check if it works

#5

Not sure if its working. How would I check? :blush:

#6

Im also not sure. Maybe cleaning ospf neigh in database to let libre recreate them?
But, again, not sure as Im not using OSPF

Other option is to make a libre dev site and test in there adding the routers.

#7

how do i rollback the patch

#8

./scripts/github-remove -s

#9

Thanks i updated last night ospf neighbors are correct now. Thanks for the fix.

#10