Services: empty graphs. Unproper code

awaum · 9 January 2020 13:36

Hi,

I got an issue with the graphing of performance data of a service check.

(I’m talking about the graphs which you can see in the “detail view” of a service, in case the check_plugin is creating performance data output)

My plugin is returning a label which contains spaces.

CPU Load 1% (5 min average) |   '5 min avg Load'=1%;90;95;0;100

This is valid according to the NAGIOS plugin develeopment guide:
http://archive.is/4sKgL#selection-1277.0-1297.81 is highlighting this.

However in the “detail view” of my service I have 4 rows of graphs. The first row is labeled “5”, the next row is labeled “min”, next is “avg” and the last row labeled “load” is finally containing the graphs for my only value (all the graphs in the other rows are empty).

Currently I don’t have a means to change the label to something without spaces… but anyway, isn’t this a bug?

Thank you!

Best regards,
awaum

slashdoom · 10 January 2020 09:48

Spaces should be okay, but that output doesn’t look valid to me. From your link…

Status output (before the pipe):

Output should be in the format:

SERVICE STATUS: Information text

Perf output (after the pipe):

This is the expected format:

'label'=value[UOM];[warn];[crit];[min];[max]

So you would expect to see something like:
OK: CPU Load 1% (5 min Avg) | '5 min Avg Load'=1%;90:95:0:100

awaum · 10 January 2020 11:53

Hi slashdoom,
thank you for your reply. You mean the “OK: missing” before the pipe?

Well, I agree that this is not good style. But in the end, it’s the return value of the plugin that marks something “OK, CRITICAL OR WARNING”… before the pipe is just text.

My issue happens after the pipe: I believe that something in the libre-code is not handing over the single quotes around the label, which would explain the issue.

Could somebody please confirm my observations?

slashdoom · 11 January 2020 02:52

I see what you’re saying. Sorry about that. The way the forum has highlighted parts of the before pipe text I thought you were saying you thought those were affecting the output.

I think I can confirm what you’re saying. See:

github.com

librenms/librenms/blob/master/includes/services.inc.php#L238


// Run the command and return its response.
exec('LC_NUMERIC="C" ' . $safe_command, $response_array, $status);


// exec returns an array, lets implode it back to a string.
$response_string = implode("\n", $response_array);


// Split out the response and the performance data.
list($response, $perf) = explode("|", $response_string);


// Split each performance metric
$perf_arr = explode(' ', $perf);


// Create an array for our metrics.
$metrics = array();


// Loop through the perf string extracting our metric data
foreach ($perf_arr as $string) {
    // Separate the DS and value: DS=value
    list ($ds,$values) = explode('=', trim($string));


    // Keep the first value, discard the others.

Line 235 splits the text first by the pipe, then the line 238 splits the perf string by space. It doesn’t look like there is currently logic built in for single quoted labels contain spaces.

awaum · 14 January 2020 09:58

Thank you for pointing this out!