Wrong PON dbm sensor limits Nokia ISAM

This thing has been bugging me for a while…values for nokia isam dbm pon sensor limits are wrong.
When you go to “Edit” > “health” you’ll find this

Clearly values for high and low are way off.

I looked at github source files and found some examples under tests/data/nokia-isam.json. Here is the snippet:

{
“sensor_deleted”: 0,
“sensor_class”: “dbm”,
“poller_type”: “snmp”,
“sensor_oid”: “.1.3.6.1.4.1.637.61.1.56.5.1.6.4355.2”,
“sensor_index”: “lt:1/1/1/2-tx”,
“sensor_type”: “nokia-isam”,
“sensor_descr”: “lt:1/1/1/2 Tx Power”,
“group”: null,
“sensor_divisor”: 1,
“sensor_multiplier”: 1,
“sensor_current”: -5.49,
“sensor_limit”: -3,
“sensor_limit_warn”: -4,
“sensor_limit_low”: -9,
“sensor_limit_low_warn”: -8,
“sensor_alert”: 1,
“sensor_custom”: “No”,
“entPhysicalIndex”: null,
“entPhysicalIndex_measured”: null,
“sensor_prev”: null,
“user_func”: null,
“state_name”: null
},
{
“sensor_deleted”: 0,
“sensor_class”: “dbm”,
“poller_type”: “snmp”,
“sensor_oid”: “.1.3.6.1.4.1.637.61.1.56.5.1.6.4356.1”,
“sensor_index”: “lt:1/1/2/1-tx”,
“sensor_type”: “nokia-isam”,
“sensor_descr”: “lt:1/1/2/1 Tx Power”,
“group”: null,
“sensor_divisor”: 1,
“sensor_multiplier”: 1,
“sensor_current”: 3.66,
“sensor_limit”: 7,
“sensor_limit_warn”: 6,
“sensor_limit_low”: -0.5,
“sensor_limit_low_warn”: 0.5,
“sensor_alert”: 1,
“sensor_custom”: “No”,
“entPhysicalIndex”: null,
“entPhysicalIndex_measured”: null,
“sensor_prev”: null,
“user_func”: null,
“state_name”: null
},

The lower part containes the sensor limit values that should be displayed in my screenshot. What i don’t understand is why both test examples show tx values? seems odd to me.

Problem with all of this is that limit values are wrong and marked in red which is inaccurate. This is true only for pon ports as far as i can see.

Please send a patch with saner values; https://github.com/librenms/librenms/blob/master/includes/discovery/sensors/dbm/nokia-isam.inc.php

I would like to help but i’m not sure what i need to do.
Do i have to make a PR and rewrite code in that file?

This topic was automatically closed 90 days after the last reply. New replies are no longer allowed.